[DRAFT] User account page & login screen #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BartoszKlonowski
changed the title
The user's data are kept in the local User instance which is pulled each time the User's account page is entered. The information can be used from the any other component via the Native module.
BartoszKlonowski
force-pushed
the
feature-user-account-functionality
branch
from
94524b5 to
d61ab3f
Compare
When trying to open the window on the separate thread (after launching the coroutine) it is possible that there'll be the exception thrown by the base.h implementation. The reason for specifying the winrt::hresult_error is that it does not inherits from the std::exception so it would be impossible to catch by the universal exception.
The FilePicker when opened was throwing the "Invalid window handle" error. This was caused by the native module thread affinity and the fact that the FilePicker should be launched in the UI thread explicitly. The fix for that is to launch the couroutine on the UI context using the UIDispatcher method of React Native Windows. for more details and the reasoning please check: https://github.com/microsoft/react-native-windows/issues/7641
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the user's account page and provides the application with the login page.